FIx handling of resource creation error when emitting JSON output #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrtalbot
approved these changes
Dec 3, 2024
seqerakit/cli.py
Outdated
Comment on lines
113
to
120
|
|
||
| # Create a separate instance of the Overwrite class without JSON output | ||
| sp_without_json = seqeraplatform.SeqeraPlatform( | ||
| cli_args=sp.cli_args, | ||
| dryrun=sp.dryrun, | ||
| json=False, | ||
| ) | ||
| self.overwrite_method = overwrite.Overwrite(sp_without_json) |
There was a problem hiding this comment.
Is this the same as #172?
There was a problem hiding this comment.
Yes, it is. Branched off of that feature branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166 to improve command output handling and JSON parsing. Modified
_execute_commandto attempt JSON parsing first before falling back to standard output handling.Changes:
print_stdoutflag for both JSON and standard output