Fix repo_upload failure handling #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: 'repodoesnotexist', | ||
| dir: 'testdir/', | ||
| file: 'test_1.0_amd64.deb').to_s, | ||
| 'local repo with name repodoesnotexist not found' |
There was a problem hiding this comment.
Align the parameters of a method call if they span more than one line.
- a 404 response previously would output a message to stdout but then continue to try to parse JSON, which would fail. - the `FailedFiles` and `Warnings` code never got executed because it was in `rescue` blocks that don't get triggered.
msabramo
force-pushed
the
fix_repo_upload_failures
branch
from
8a7b026
to
e957508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue to try to parse JSON, which would fail.
FailedFilesandWarningscode never got executed because itwas in
rescueblocks that don't get triggered.