Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use internal Java code instead of FFmpeg to split long WAV audio files (#1267) #1543

Merged
merged 4 commits into from
Feb 25, 2023
Merged

Use internal Java code instead of FFmpeg to split long WAV audio files (#1267) #1543

merged 4 commits into from
Feb 25, 2023

Conversation

wladimirleite
Copy link
Member

Closes #1267.

@lfcnassif
Copy link
Member

Thank you @tc-wleite!

lfcnassif
lfcnassif approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@lfcnassif lfcnassif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tc-wleite. I force pushed to change a commit message to the right issue number.

@lfcnassif lfcnassif merged commit f01cadd into master Feb 25, 2023
@lfcnassif lfcnassif deleted the #1267_WavSplit branch February 25, 2023 23:35
@wladimirleite
Copy link
Member Author

I force pushed to change a commit message to the right issue number.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfcnassif lfcnassif lfcnassif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makes Google and Wav2Vec2 audio transcription not dependent of FFmpeg anymore
2 participants
@wladimirleite @lfcnassif