Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map previous/next buttons first click after sorting change are considering previous sorting order #697

Closed
lfcnassif opened this issue Aug 13, 2021 · 6 comments
Closed

Map previous/next buttons first click after sorting change are considering previous sorting order #697

lfcnassif opened this issue Aug 13, 2021 · 6 comments
Assignees
@patrickdalla
Labels
bug

Comments

@lfcnassif
Copy link
Member

This is a minor issue discovered in #680, happens just after changing table sorting column and just on first button click, subsequent clicks work as expected.
@lfcnassif lfcnassif added the bug label Aug 13, 2021
@lfcnassif lfcnassif changed the title Map previous/next buttons first click are not respecting table tab sorting after sorting changes Map previous/next buttons first click after sorting change are considering previous sorting order Aug 16, 2021
@lfcnassif
Copy link
Member Author

@patrickdalla did you have a chance to look at this?

@patrickdalla
Copy link
Collaborator

I've just finished the implementation of the bug correction on MapNavigationBug branch. See there and make the final tests.

@patrickdalla patrickdalla mentioned this issue Sep 13, 2022
Closed
@lfcnassif
Copy link
Member Author

@patrickdalla I assigned this to you, so others will know you are working on this (thanks!) to avoid duplicate efforts

@patrickdalla
Copy link
Collaborator

I have already implemented this correction on MapNavigationBugCorrection2. Should I create a PR?

@lfcnassif
Copy link
Member Author

Yes, please!

lfcnassif added a commit that referenced this issue Sep 29, 2022
@lfcnassif
'#697: reverts unneeded pom.xml change
f96624a
lfcnassif added a commit that referenced this issue Sep 29, 2022
@lfcnassif
'#697: fix bad indentation with tabs and organize imports
5da0e62
lfcnassif added a commit that referenced this issue Sep 30, 2022
@lfcnassif
'#697: undo unneeded changes of bd62687, put back simpler prev code
7df3fbf
@lfcnassif
Copy link
Member Author

Fixed by #1333

lfcnassif added a commit that referenced this issue Oct 4, 2022
@lfcnassif
'#697: reverts unneeded pom.xml change
7dbf263
lfcnassif added a commit that referenced this issue Oct 4, 2022
@lfcnassif
'#697: fix bad indentation with tabs and organize imports
17843fe
lfcnassif added a commit that referenced this issue Oct 4, 2022
@lfcnassif
'#697: undo unneeded changes of bd62687, put back simpler prev code
734f272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickdalla patrickdalla

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lfcnassif @patrickdalla