-
Notifications
You must be signed in to change notification settings - Fork 218
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Never add video: prefix to transcription properties #1801
Comments
|
I don't know if it is a good idea to expose this, as it will send the entire video file, which maybe large, over the network. In this case I think that the audio should be extracted in the client. |
I agree. For videos, running MPlayer locally before sending to transcription server makes more sense. Another detail, maybe the conversion command can be slightly changed to improve performance, completely ignoring the video channel. Not sure if it already does that. I will check this later and update here. |
Thanks @hauck-jvsh, I agree, but the option was already exposed, user was already able to change the configuration, I just fixed the property name. Let's open another ticket to improve video transcription resource usage. Thanks @tc-wleite, let us know if the command can be improved. |
I changed my mind and will tag this as bug. |
Just tested transcription on videos simply adding
video
intomimesToProcess
inAudioTranscriptConfig
. I thought it would be necessary to update theconvertCommand
(and that's why I exposed it to interested users) but it wasn't needed (reported by @hauck-jvsh before).But transcription results are being prefixed by
video:
. That's not good because it splits results between different properties and it also avoids to embed the video transcriptions into chats properly.The text was updated successfully, but these errors were encountered: