Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems decoding Cyrillic and other unicode chars from registry files #1664

Closed
NightShadow777 opened this issue Apr 27, 2023 · 9 comments
Closed
Assignees
Labels

Comments

@NightShadow777
Copy link

NightShadow777 commented Apr 27, 2023

Hi!
On time IPED build on Windows OS via maven 3.2.5
an error occurs in the file: GalleryModel.java line 251,
image = ImageMetaDataUtil.getThumb(CloseShieldInputStream.wrap(stream);
Doesn't find the wrap method. I replaced with this code:
image = ImageMetaDataUtil.getThumb(CloseShieldInputStream.nullInputStream());

Also during the build process, the following error occurs: commons-io was not found in iped-app, added to the pom.xml file:

   <dependency>
         <groupId>commons-io</groupId>
         <artifactId>commons-io</artifactId>
         <version>2.8.0</version>
     </dependency>

After these edits it was built successfully. When working with iPED, I noticed that it incorrectly processes Cyrillic.

P.S. I started to translate into Ukrainian and Russian lang...

@lfcnassif
Copy link
Member

Hi @NightShadow777,

What java JDK version are you using? Are you building with pure maven from command line or are you using an IDE? If the last, maybe there are some dependency conflict in your IDE environment...

And could you be more specific about what doesn't work with Cyrillic and provide an example? Indexed searches, file rendering, table sorting?

P.S. I started to translate into Ukrainian and Russian lang...

Great! Thank you very much @NightShadow777 for helping the project!

But would you be able to help us maintaining and updating those translations for future versions? Usually new versions have more features and more strings to be translated...

@NightShadow777
Copy link
Author

I am using Java JDK version 11.0.19+7. At first I wanted to build IntelliJ in the IDE, but it didn’t work out because
couldn’t find the commons-io library, although I installed it manually through maven. Therefore, I downloaded maven 3.2.5 and decided to build it without an IDE, during the build there were also errors described above.

Cyrillic errors occur in:

  • result of sqlite database parsing
  • result of registry parsing username and path

Yes, I will help with the support of translations into Ukrainian and Russian, when they are ready I will send them to you.

There are a couple more ideas on the viber messenger, there is a ready-made module in python, but as a friend of the software, when I finish with the translations, I will try to make it for the iPed.

screenshot.zip

P.S. Sorry for the quality of the screenshots

@lfcnassif
Copy link
Member

Great! Thank you very much again for helping the project!

I'll try to reproduce the building issues.

About the Cyrillic issues, would you be able to share a sample sqlite or registry file so we could reproduce the issues and test a future fix?

@NightShadow777
Copy link
Author

I will try to throw it on Monday, if possible it is better through whatsapp or telegram

@NightShadow777
Copy link
Author

happy weekend)

@lfcnassif
Copy link
Member

I will try to throw it on Monday, if possible it is better through whatsapp or telegram

Thank you very much, you can send them to my email on my profile if it works for you.

I am using Java JDK version 11.0.19+7. At first I wanted to build IntelliJ in the IDE, but it didn’t work out because
couldn’t find the commons-io library, although I installed it manually through maven. Therefore, I downloaded maven 3.2.5 and decided to build it without an IDE, during the build there were also errors described above.

I have just cloned master (I'm supposing you tried to build that branch, or not?) from scratch on another computer with Windows 10 and compiled the project using latest maven-3.9.1 and JDK 11.0.19 too, that finished without problems. The build is also working fine on Github CI (Ubuntu 22.04). Maven 3.2.5 is too old, from 2014. Please give the latest maven version a try.

happy weekend)

To you too :-)

@lfcnassif lfcnassif added the bug label Apr 28, 2023
@NightShadow777
Copy link
Author

Hi, @lfcnassif !
Files in which problems with Cyrillic were found were attached to the letter.
Thank you

@lfcnassif
Copy link
Member

Thank you!

@lfcnassif
Copy link
Member

lfcnassif commented May 1, 2023

Thanks for the files, I was able to reproduce the issues with sqlite and registry files parsing, a wrong charset is being used to read the results, I'll push the fixes shortly. I'll update the title to better describe the issue related to registry files and open a new one to better describe the issue with sqlite.

Please also test if the building with maven-3.9.1 still fails on your machine.

Thank you!

@lfcnassif lfcnassif changed the title Errors during the build from sources and problems with Cyrillic in artifacts. Problems decoding Cyrillic and other unicode symbols from registry files May 1, 2023
@lfcnassif lfcnassif self-assigned this May 1, 2023
@lfcnassif lfcnassif changed the title Problems decoding Cyrillic and other unicode symbols from registry files Problems decoding Cyrillic and other unicode chars from registry files May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants