Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some chat messages from UFDR reports being duplicated #1585

Closed
lfcnassif opened this issue Mar 9, 2023 · 2 comments
Closed

Some chat messages from UFDR reports being duplicated #1585

lfcnassif opened this issue Mar 9, 2023 · 2 comments
Assignees
@lfcnassif
Labels
bug

Comments

@lfcnassif
Copy link
Member

lfcnassif commented Mar 9, 2023 •
edited
Loading

In a specific sample (kindly created by @gisms) most of them are duplicated. Seems they are related to media messages:
image
@lfcnassif lfcnassif added the bug label Mar 9, 2023
lfcnassif added a commit that referenced this issue Mar 10, 2023
@lfcnassif
'#1585: avoid inserting duplicate attachs with same ufed:id in chat html
37b4394
@lfcnassif lfcnassif self-assigned this Mar 10, 2023
@lfcnassif lfcnassif changed the title Some chat messages from external decoding being duplicated Some chat messages from UFED decoding being duplicated Mar 10, 2023
@lfcnassif lfcnassif changed the title Some chat messages from UFED decoding being duplicated Some chat messages from PA results being duplicated Mar 10, 2023
@lfcnassif
Copy link
Member Author

Messages were not just being duplicate in chat preview, but also in the case into "Instant Messages" category, this is not good for the Graph module that would take much longer to import them. Not sure if UFDR format changed at some point, but it's working fine locally, I'll push the fix shortly.

@lfcnassif
Copy link
Member Author

I took a look at some old UFDR reports, some of them have <modelType type="InstantMessage"> element in report.xml, some not. Not sure if that depends on report creation configs or if in the past just recovered deleted messages without a parent chat were put there and now all of them are put there and into the chat section (causing the duplication...)

lfcnassif added a commit that referenced this issue Mar 12, 2023
@lfcnassif
'#1585: avoid inserting duplicate attachs with same ufed:id in chat html
c39e993
@lfcnassif lfcnassif changed the title Some chat messages from PA results being duplicated Some chat messages from UFDR reports being duplicated Mar 13, 2023
lfcnassif added a commit that referenced this issue Mar 13, 2023
@lfcnassif
'#1585: avoid inserting duplicate attachs with same ufed:id in chat html
dd2d95e
lfcnassif added a commit that referenced this issue Mar 13, 2023
@lfcnassif
fix #1585: don't include duplicate instant messages in the case
2c42af5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfcnassif lfcnassif

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lfcnassif