feature: optional pandas and polars support #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TyberiusPrime |
TyberiusPrime
force-pushed
the
pandas_polars
branch
from
cbee311 to
dae46b7
Compare
|
My apologies, I had rebased against dev before creating the PR (but after starting the creation...) and github somehow didn't pick that up. Give me a minute to learn how to fix this. edit: Turns out it's as easy as hitting 'edit' at the top and selecting a new target branch. Now the diff looks much more reasonable as well. |
|
LGTM! Thanks @TyberiusPrime |
|
@TyberiusPrime DeepDiff 8.0.0 is published and it includes your contribution. Thank you! |
TyberiusPrime
added a commit
to TyberiusPrime/pypipegraph2
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394.
I recently ran into an issue where my pipipegraph2 failed to to recalculate nodes downstream of a changed output because deepdiff assigned the same hash to different DataFrames.
Turns out, it was essentially only hashing the column names.
This PR fixes that for pandas, and while I had it open, for polars as well.
The code paths are optional on a successful pandas/polars import.
The added tests of course require pandas and polars. I tried for both with the older versions I listed in requirements-dev.txt and the current versions
I observe 3 failing & 3 error test cases here locally,
but they also failed before I touched the code, so I'll blame them on my local venv.