-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeepDiff not excluding paths when ignore_order is True #174
Comments
We are seeing the same issue with DeepDiff 4.0.9 |
Just ran into this, still happening with 4.2.0 |
Hi @bbushnell95 |
This issue is resolved. v4.3.1 is released. An example can be found in the tests: https://github.com/seperman/deepdiff/blob/master/tests/test_diff_text.py#L1612 The underlying issue was in DeepHash and is fixed in this commit: eb3973a Closing this ticket! |
v4-3-2: Deprecation Warning Enhancement v4-3-1: Fixing the issue with exclude_path and hash calculations when dictionaries were inside iterables. seperman/deepdiff#174 v4-3-0: adding exclude_obj_callback v4-2-0: .json property is finally removed. Fix for Py3.10. Dropping support for EOL Python 3.4. Ignoring private keys when calculating hashes. For example init is not a part of hash calculation anymore. Fix for 166 Problem with comparing lists, with an boolean as element. v4-0-9: Fixing the bug for hashing custom unhashable objects v4-0-8: Adding ignore_nan_inequality for float('nan')
Describe the bug
When attempting to do a diff between two lists of dictionaries, if ignore_order is defined as True, and exclude_paths is provided, the exclude_paths appears to not be accounted for.
To Reproduce
Steps to reproduce the behavior:
e
field of obj1a to be the same as obj1['e'], DeepDiff will return an empty object, as expected.Expected behavior
Output of the above should show no diff, as e should be excluded from the paths.
Expected output:
OS, DeepDiff version and Python version (please complete the following information):
The text was updated successfully, but these errors were encountered: