-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coc update #425
Coc update #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes needed.
.github/CODE_OF_CONDUCT.md
Outdated
@@ -1,76 +1,132 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra new line here.
.github/CODE_OF_CONDUCT.md
Outdated
* Other conduct which could reasonably be considered inappropriate in a | ||
professional setting | ||
professional setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space here.
Codecov Report
@@ Coverage Diff @@
## dev #425 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 11 11
Lines 2401 2401
Branches 387 387
=======================================
Hits 2383 2383
Misses 6 6
Partials 12 12 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alirezazolanvari Thanks for your efforts 💯
Please update the changelog.
Something like :
CODE_OF_CONDUCT.md
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Reference Issues/PRs
#399
Update the code of conduct according to the Contributor Covenant, version 2.1, available here.