Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coc update #425

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Coc update #425

merged 4 commits into from
Mar 4, 2022

Conversation

alirezazolanvari
Copy link
Collaborator

@alirezazolanvari alirezazolanvari commented Mar 3, 2022

Reference Issues/PRs

#399

Update the code of conduct according to the Contributor Covenant, version 2.1, available here.

Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed.

@@ -1,76 +1,132 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra new line here.

* Other conduct which could reasonably be considered inappropriate in a
professional setting
professional setting
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #425 (354f938) into dev (0f10c00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #425   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          11       11           
  Lines        2401     2401           
  Branches      387      387           
=======================================
  Hits         2383     2383           
  Misses          6        6           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f10c00...354f938. Read the comment docs.

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alirezazolanvari Thanks for your efforts 💯
Please update the changelog.
Something like :
CODE_OF_CONDUCT.md updated

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sepandhaghighi sepandhaghighi merged commit 0da00ed into dev Mar 4, 2022
@sepandhaghighi sepandhaghighi deleted the CoC branch March 4, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants