Converting na values to empty string, then removing items with value … #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of empty string We reccommend to customers to remove empty values, so we should too.
For release 1.3.2
docktermj
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of empty string
We recommend to customers to remove empty values, so we should too.
Pull request questions
Which issue does this address
Issue number: #49
Why was change needed
Empty strings were converted to N/A values causing an exception when the records was loaded
What does change improve
All values are read in as strings, N/A values are converted to "", and we remove items a value of "" to follow our own recommendation to customers.