Skip to content

Commit

Permalink
#334 Fix docker build process (#348)
Browse files Browse the repository at this point in the history
  • Loading branch information
docktermj authored Oct 21, 2024
1 parent bfa734e commit 64474ba
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 25 deletions.
2 changes: 1 addition & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ docs/
CHANGELOG.md
CODE_OF_CONDUCT.md
CONTRIBUTING.md
docker-compose.test.yml
docker-compose.test.yaml
LICENSE
README.md
12 changes: 0 additions & 12 deletions makefiles/darwin.mk
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ SENZING_TOOLS_DATABASE_URL ?= sqlite3://na:na@nowhere/tmp/sqlite/G2C.db
# OS specific targets
# -----------------------------------------------------------------------------

.PHONY: build-osarch-specific
build-osarch-specific: darwin/amd64


.PHONY: clean-osarch-specific
clean-osarch-specific:
@docker rm --force $(DOCKER_CONTAINER_NAME) 2> /dev/null || true
Expand Down Expand Up @@ -49,14 +45,6 @@ dependencies-for-development-osarch-specific:
@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin latest


.PHONY: docker-build-osarch-specific
docker-build-osarch-specific:
@docker build \
--tag $(DOCKER_IMAGE_NAME) \
--tag $(DOCKER_IMAGE_NAME):$(BUILD_VERSION) \
.


.PHONY: documentation-osarch-specific
documentation-osarch-specific:
@pkill godoc || true
Expand Down
9 changes: 9 additions & 0 deletions makefiles/darwin_x86_64.mk
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@
.PHONY: build-osarch-specific
build-osarch-specific: darwin/amd64


.PHONY: docker-build-osarch-specific
docker-build-osarch-specific:
@docker build \
--platform linux/amd64 \
--tag $(DOCKER_IMAGE_NAME) \
--tag $(DOCKER_IMAGE_NAME):$(BUILD_VERSION) \
.

# -----------------------------------------------------------------------------
# Makefile targets supported only by this platform.
# -----------------------------------------------------------------------------
Expand Down
12 changes: 0 additions & 12 deletions makefiles/linux.mk
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ PATH := $(MAKEFILE_DIRECTORY)/bin:/$(HOME)/go/bin:$(PATH)
# OS specific targets
# -----------------------------------------------------------------------------

.PHONY: build-osarch-specific
build-osarch-specific: linux/amd64


.PHONY: clean-osarch-specific
clean-osarch-specific:
@docker rm --force $(DOCKER_CONTAINER_NAME) 2> /dev/null || true
Expand Down Expand Up @@ -44,14 +40,6 @@ dependencies-for-development-osarch-specific:
@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin latest


.PHONY: docker-build-osarch-specific
docker-build-osarch-specific:
@$(DOCKER_BUILDKIT) docker build \
--tag $(DOCKER_IMAGE_NAME) \
--tag $(DOCKER_IMAGE_NAME):$(BUILD_VERSION) \
.


.PHONY: documentation-osarch-specific
documentation-osarch-specific:
@pkill godoc || true
Expand Down
9 changes: 9 additions & 0 deletions makefiles/linux_x86_64.mk
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ build-osarch-specific: linux/amd64
@mkdir -p $(TARGET_DIRECTORY)/linux
@cp $(TARGET_DIRECTORY)/linux-amd64/$(PROGRAM_NAME) $(TARGET_DIRECTORY)/linux/$(PROGRAM_NAME)


.PHONY: docker-build-osarch-specific
docker-build-osarch-specific:
@docker build \
--platform linux/amd64 \
--tag $(DOCKER_IMAGE_NAME) \
--tag $(DOCKER_IMAGE_NAME):$(BUILD_VERSION) \
.

# -----------------------------------------------------------------------------
# Makefile targets supported only by this platform.
# -----------------------------------------------------------------------------
Expand Down

0 comments on commit 64474ba

Please sign in to comment.