#690 #689 graph node coloring changes #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arawinters
added
bug
docktermj
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request questions
Which issue does this address
resolves #689
resolves #690
Why was change needed
When selecting datasource colors if the primary node color is chosen and the primary node is part of that datasource the color displayed is the color chosen for the primary and not the datasource member color.
Additionally a critical bug was found while working on this issue that causes an infinite re-render loop. This PR includes the fix for that issue as well( #689 )
What does change improve
Changing this behavior will allow the primary focused node's color to be changed to the color of it's datasource if a color has been chosen. Additionally there is a new behavior to UNSET the chosen color be selecting either pure white(#ffffff) or pure black(#000000) in the color picker. Being able to unset a chosen color for a datasource that the primary node is a member off will return it's color to the color selected for focused/primary nodes.