This repository has been archived by the owner on Jan 7, 2020. It is now read-only.
vendor: Update mapstructure to 1.0.0 #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapstructure 1.0.0 includes a fix for a data race in decodeStruct() that's been causing segfaults in our environment. Upstream fix: mitchellh/mapstructure@7869cdb Signed-off-by: Andrew Gunnerson <andrew.gunnerson@us.ibm.com>
|
Hi @agunnerson-ibm, This change makes sense to me. Were you able to test the change in your environment(s)? |
|
@amdprophet Yep, we've been running Uchiwa with this patch in all of our environments since around the middle of September and we didn't run into any more segfaults. |
|
Awesome, thank you for this patch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the vendored mapstructure dependency to version 1.0.0, which includes a fix for a race condition that can lead to segfaults: mitchellh/mapstructure@7869cdb
Related Issue
#798
Motivation and Context
This change fixes a segfault that occurs from simply leaving Uchiwa running.
How Has This Been Tested?
All unit tests pass. I'll build new RPMs and test them in our environment.
Types of changes
Checklist: