Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

Add concurrency to buildClients() #784

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Conversation

amdprophet
Copy link
Member

@amdprophet amdprophet commented Jun 5, 2018

Signed-off-by: Justin Kolberg amd.prophet@gmail.com

Description

Adds concurrency to the buildClients() method.

Related Issue

N/A

Motivation and Context

The buildClients() method takes a significant amount of time to complete with a large number of clients & events. For example, with 18000 clients & events it was taking 2m1.553801286s to complete. With these changes it now takes 21.951286761s.

How Has This Been Tested?

Added some log lines to benchmark performance. Started Uchiwa & verified data was still getting populated.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
@teekennedy
Copy link

teekennedy commented Jun 5, 2018

LGTM

@codecov-io
Copy link

Codecov Report

Merging #784 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
- Coverage   21.59%   21.54%   -0.06%     
==========================================
  Files          28       28              
  Lines        2454     2460       +6     
==========================================
  Hits          530      530              
- Misses       1859     1865       +6     
  Partials       65       65
Impacted Files Coverage Δ
uchiwa/daemon/clients.go 52.3% <0%> (-5.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815ad56...ee52a00. Read the comment docs.

@amdprophet amdprophet merged commit 645a3dc into master Jun 5, 2018
@amdprophet amdprophet deleted the concurrent-buildClients branch June 5, 2018 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants