Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

Various optimizations #719

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Conversation

palourde
Copy link
Contributor

Description

  • Use io.ReadFull instead of ioutil.ReadAll when reading Sensu API responses
  • Add advanced configuration settings for Sensu APIs HTTP clients

Related Issue

N/A

Motivation and Context

Prevent EOF errors

How Has This Been Tested?

Manual testing!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Sep 29, 2017

Codecov Report

Merging #719 into master will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage    21.2%   21.53%   +0.32%     
==========================================
  Files          27       27              
  Lines        2862     2874      +12     
==========================================
+ Hits          607      619      +12     
  Misses       2196     2196              
  Partials       59       59
Impacted Files Coverage Δ
uchiwa/main.go 39.72% <100%> (+11.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0df42...94d8eb6. Read the comment docs.

@palourde palourde merged commit 0ab2c83 into sensu:master Sep 29, 2017
@palourde palourde deleted the feature/optimizations branch September 29, 2017 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants