Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

Silenced refactoring #657

Merged
merged 3 commits into from
Mar 21, 2017
Merged

Silenced refactoring #657

merged 3 commits into from
Mar 21, 2017

Conversation

palourde
Copy link
Contributor

@palourde palourde commented Mar 21, 2017

Description

  • Remove the angular-mass-autocomplete dependency for the HTML5 datalist
  • Add the angular-moment-picker dependency as the datetime picker
  • Add the SilenceDurations attribute in UsersOptions in order to customize durations

Related Issue

Resolves #644.

Depends on https://github.com/sensu/uchiwa-web/pull/143.

How Has This Been Tested?

Unit & manual testing.

Screenshots (if appropriate):

screen shot 2017-03-21 at 10 34 29

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation. (palourde/uchiwa-docs@b136d21)
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Mar 21, 2017

Codecov Report

Merging #657 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   22.83%   22.83%           
=======================================
  Files          26       26           
  Lines        2102     2102           
=======================================
  Hits          480      480           
  Misses       1565     1565           
  Partials       57       57
Impacted Files Coverage Δ
uchiwa/config/config.go 68.61% <ø> (ø) ⬆️
uchiwa/server.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32fbc5...a10d556. Read the comment docs.

@palourde palourde merged commit 5d7927d into sensu:master Mar 21, 2017
@palourde palourde deleted the refactoring-silenced branch March 21, 2017 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silencing should support all possible subscription/check combinations
2 participants