Fixissue197

[zanloy]

This should fix issue #197, the final commit removes an unnecessary function call that errored if you did not define "install_repo => 'true'" (notice single quotes) in your class declaration. The default was true which is already a bool.

[jamtur01]

Neat! Thanks!

[jamtur01]

@zanloy Looks like the tests are failing. I am going to revert - can you please update and fix tests! Thanks!

[zanloy]

How are you doing testing? rspec? Rake?

[jamtur01]

https://github.com/sensu/sensu-puppet/tree/master/spec and here is the failed build https://travis-ci.org/sensu/sensu-puppet/builds/35543287

[zanloy]

I can't fix that test requirement. It's the File['/etc/sensu/plugins'] declaration that was actually causing the issue. I have to rename the file declaration to prevent puppet from redeclaring what is already declared in package.pp:63. I have tested in my own environment using the following declaration that causes the initial error:

class { 'sensu':
rabbitmq_host => $host,
rabbitmq_port => $port,
rabbitmq_vhost => $vhost,
rabbitmq_password => $password,
subscriptions => $subscriptions,
rabbitmq_ssl_private_key => "puppet:///modules/profiles/sensu/ssl/client.key",
rabbitmq_ssl_cert_chain => "puppet:///modules/profiles/sensu/ssl/client.crt",
use_embedded_ruby => $use_embedded_ruby,
}

sensu::plugin { 'puppet:///modules/profiles/sensu/plugins':
type => 'directory',
}

[zanloy]

Here is the error thrown from the initial issue:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate declaration: File[/etc/sensu/plugins] is already declared in file /etc/puppetlabs/puppet/enviro
nments/production/modules/sensu/manifests/package.pp:63; cannot redeclare at /etc/puppetlabs/puppet/environments/production/modules/sensu/manifests/plugin.pp:81 on node puppet.lab.
stopso.com

[zanloy]

I'm very new to github but if I can change the rspec test then I can get it to pass. I wasn't sure if changing test was bad etiquette or not.