Add optional pipe property to sensu_handler #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlambert121 Any feedback? @yeungda Can you please rebase. |
This builds on work already merged for supporting the pipe transport. It provides validation that the pipe is a hash and adds a spec. This makes the pipe property's implementation more consistent with other properties.
|
In summary this just adds some additional validation and a spec. The pipe is validated as a hash, and a typo was fixed in the check that ensures pipe is present when the type is transport. |
jamtur01
added a commit
that referenced
this pull request
Sep 12, 2014
Add optional pipe property to sensu_handler
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipe property is a hash. It is required when describing a sensu
handler of type transport. The transport type was introduced in sensu
0.13 and replaces the amqp type.