updated native types and providers to use base_path/config when puppet i... #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is run under nonroot user
* this is needed because if sensu is run with a nonroot user
the config files cannot be used as they are owned by root
thus puppet cannot conigure what it does not have access to.
* This is part 1 of what needs to be changed, since this sets
defaults for base_path we can add this ability now and work
on the manifests to be nonroot compliant later.
|
@jamtur01 thoughts? |
|
I am on the fence about this. I don't have the use case but I can see why others might. I am happy if you are happy @jlambert121 |
jlambert121
added a commit
that referenced
this pull request
May 1, 2014
updated native types and providers to use base_path/config when puppet i...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this module is written for puppet with the root user in mind as are most modules. For folks like me where we don't have root control we need a way to tell puppet where the files are since this module hard codes the path by default. I have added a base path parameter that allows one to override the default location of the config file for all native types. Additionally, the parameter defaults to the originally hard coded value so that this parameter is purely optional.
This is part 1 of what needs to be changed, since this sets defaults for base_path we can add this ability now and work on the manifests to be nonroot compliant later.
I already have a completely finished non root module working but need to generalize most of the variable names in order to make them consumable by everyone. So there will be a part two that updates the manifests to be non root friendly.