Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AWS S3 mirroring optional #330

Closed
Tracked by #333
calebhailey opened this issue Sep 27, 2021 · 1 comment · Fixed by #343
Closed
Tracked by #333

Make AWS S3 mirroring optional #330

calebhailey opened this issue Sep 27, 2021 · 1 comment · Fixed by #343
Assignees
@demillir
Labels
on staging
Milestone
6.6.0

Comments

@calebhailey
Copy link

Prepare Bonsai for on-prem deployments where users might not need support for mirroring assets on S3.
@calebhailey calebhailey added this to the 6.6.0 milestone Sep 27, 2021
@calebhailey calebhailey mentioned this issue Sep 27, 2021
Open
4 tasks
demillir added a commit that referenced this issue Dec 7, 2021
@demillir
Add the S3_MIRRORING environment flag
5c572a8 
as per #330
demillir added a commit that referenced this issue Dec 7, 2021
@demillir
Add the S3_MIRRORING environment flag
3602699 
as per #330
@demillir demillir mentioned this issue Dec 7, 2021
Merged
demillir added a commit that referenced this issue Dec 8, 2021
@demillir
Add the S3_MIRRORING environment flag
d138c19 
as per #330
demillir added a commit that referenced this issue Dec 8, 2021
@demillir
Add the S3_MIRRORING environment flag
be9398c 
as per #330
@jspaleta
Copy link

jspaleta commented Jan 25, 2022 •
edited
Loading

Testing on staging.

Expected behavior

  • newly added asset jspaleta/sensu-plugins-puppet shows github download urls as expected in asset definition
  • adding new version (0.1.4) to existing asset jspaleta/sensu-asset-playground and new version asset def has github urls
  • switching envvar to true and recompiling jspaleta/sensu-asset-playground switched new version urls to aws s3

Unexpected behavior

pre-existing versions for asset jspaleta/sensu-asset-playground after recompile still shows s3 urls in asset definition.

demillir added a commit that referenced this issue Mar 15, 2022
@demillir
Add the S3_MIRRORING environment flag
06ecb46 
as per #330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@demillir demillir

Labels
on staging
Projects
None yet
Milestone
6.6.0
Development

Successfully merging a pull request may close this issue.

Dan/330 s3 optional sensu/bonsai
4 participants
@jspaleta @calebhailey @mbiang @demillir