Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Conformance To Style Standards With RuboCop & TravisCI #71

Merged
merged 4 commits into from
Sep 1, 2020
Merged

chore: Conformance To Style Standards With RuboCop & TravisCI #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a58666e
edit rubocop config
alanunruh Oct 8, 2018
f514f71
implement rubocop code edits
alanunruh Oct 8, 2018
c643727
edit rubocop config with travis
alanunruh Oct 8, 2018
2626d9a
increase max line length
Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ ParameterLists:
AbcSize:
Max: 34

# Increase max number of "/" in %r
RegexpLiteral:
MaxSlashes: 0

# Increase the max line number of class
ClassLength:
Max: 250
Expand All @@ -30,3 +26,6 @@ CyclomaticComplexity:

PerceivedComplexity:
Max: 11

Metrics/LineLength:
Max: 100
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ install:
gem install bundler:1.14.6; bundle install

test:
rubocop
rake test
41 changes: 20 additions & 21 deletions lib/smtpapi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,26 @@ def set_ip_pool(pool_name)
self
end

def json_string
escape_unicode(to_array.to_json)
end
alias_method :to_json, :json_string

def escape_unicode(str)
str.unpack('U*').map do |i|
if i > 65_535
"\\u#{format('%04x', ((i - 0x10000) / 0x400 + 0xD800))}" \
"\\u#{format('%04x', ((i - 0x10000) % 0x400 + 0xDC00))}"
elsif i > 127
"\\u#{format('%04x', i)}"
else
i.chr('UTF-8')
end
end.join
end

protected

def to_array
data = {}
data['to'] = @to unless @to.empty?
Expand All @@ -132,26 +152,5 @@ def to_array

data
end

protected :to_array

def json_string
escape_unicode(to_array.to_json)
end

alias :to_json :json_string

def escape_unicode(str)
str.unpack('U*').map do |i|
if i > 65_535
"\\u#{format('%04x', ((i - 0x10000) / 0x400 + 0xD800))}" \
"\\u#{format('%04x', ((i - 0x10000) % 0x400 + 0xDC00))}"
elsif i > 127
"\\u#{format('%04x', i)}"
else
i.chr('UTF-8')
end
end.join
end
end
end
4 changes: 2 additions & 2 deletions smtpapi.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ Gem::Specification.new do |spec|
spec.license = 'MIT'

spec.files = `git ls-files -z`.split("\x0")
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.executables = spec.files.grep(/^bin/) { |f| File.basename(f) }
spec.test_files = spec.files.grep(/^(test|spec|features)/)
spec.require_paths = ['lib']

spec.add_development_dependency 'rake'
Expand Down