Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update url in "DYNAMIC_TEMPLATE_CHAR_WARNING" to point to a working current link #943

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

NickFoden
Copy link
Contributor

Fixes

Checklist

  • [ X] I acknowledge that all my contributions will be made under the project's license
  • [ X] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [X ] I have read the [Contribution Guide] and my PR follows them.
  • [N/A] I updated my branch with the development branch.
  • [ N/A ] I have added tests that prove my fix is effective or that my feature works
  • [ N/A] I have added necessary documentation about the functionality in the appropriate .md file
  • [ N/A ] I have added in line documentation to the code I modified

Short description of what this PR does:

  • The link in warning for DYNAMIC_TEMPLATE_CHAR_WARNING was to old url

If you have questions, please send an email to Twilio SendGrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 11, 2019
@NickFoden NickFoden changed the title Update url to point to a working current link Update url in "DYNAMIC_TEMPLATE_CHAR_WARNING" to point to a working current link Jun 11, 2019
@NickFoden
Copy link
Contributor Author

HI @thinkingserious i just wanted to update a warning to go to a working url. Let me know if i should make a proper issue as well. Happy to do it !

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: bug bug in the library type: docs update documentation change not affecting the code and removed status: code review request requesting a community code review or review from Twilio labels Jun 12, 2019
@thinkingserious thinkingserious merged commit 7488fa5 into sendgrid:master Jun 12, 2019
@thinkingserious
Copy link
Contributor

Hello @NickFoden,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@NickFoden
Copy link
Contributor Author

Awesome thank you !

@childish-sambino childish-sambino changed the title Update url in "DYNAMIC_TEMPLATE_CHAR_WARNING" to point to a working current link docs: Update url in "DYNAMIC_TEMPLATE_CHAR_WARNING" to point to a working current link Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: bug bug in the library type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants