Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade request to 2.88.0 (latest) to address issue #661 #757

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

GuyKh
Copy link
Contributor

@GuyKh GuyKh commented Oct 2, 2018

Fixes #661

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Upgrading request dependency to latest to fix inner dependency request@2.83.0 > hawk@6.0.2 > hoek@4.2.0 vounrability

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 2, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added hacktoberfest difficulty: easy fix is easy in difficulty type: security known security issue status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @GuyKh,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit d49b78b into sendgrid:master Oct 3, 2018
@GuyKh
Copy link
Contributor Author

GuyKh commented Oct 4, 2018

@thinkingserious - signed up.
Thanks! :)
I'd love to get some swag :) That's awesome!

@GuyKh GuyKh deleted the patch-1 branch October 4, 2018 10:20
@thinkingserious
Copy link
Contributor

Awesome! Just be sure to accumulate enough points :)

5 "difficulty: easy" or 2 "difficulty: medium" or 1 "difficulty: hard" or "difficulty: very hard".

Good luck!

@thinkingserious
Copy link
Contributor

Hello @GuyKh,

Thanks again for the PR!

We noticed that you have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @GuyKh,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: security known security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sendgrid/client dependency causes security risk
3 participants