Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial DigitalOcean tutorial commit #510

Merged
merged 4 commits into from
Feb 20, 2018

Conversation

devchas
Copy link
Contributor

@devchas devchas commented Oct 19, 2017

Create a tutorial to deploy a simple Hello Email app on Digital Ocean with Node.js using this SDK

#464

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 19, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 19, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

This is awesome @devchas! Thanks!

Do you mind resolving the conflict?

@devchas
Copy link
Contributor Author

devchas commented Oct 30, 2017

Done @thinkingserious

@thinkingserious
Copy link
Contributor

@devchas

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devchas! Thanks for the PR. Unfortunately, it looks like some other changes that were merged into the sendgrid-nodejs codebase have resulted in a merge conflict, so we need you to rebase your code. Once your PR applies cleanly to master, please let us know so that we can merge it!

@clee clee removed the status: code review request requesting a community code review or review from Twilio label Feb 14, 2018
@devchas devchas merged commit 13af4a6 into sendgrid:master Feb 20, 2018
@thinkingserious
Copy link
Contributor

Hello @devchas,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants