-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo #407
Monorepo #407
Conversation
- Handling of camelCase vs snake_case - Removed content helper class - Updated readme - Refactor mail create helper
I can't seem to get the following to work: const client = require('@sendgrid/client');
client.setApiKey(process.env.SENDGRID_API_KEY);
const data = [
"127.0.0.1"
];
const request = {
method: 'PUT',
body: data,
url: '/v3/subusers/test_subuser_name/ips'
};
client.request(request)
.then(([response, body]) => {
console.log(response.statusCode);
console.log(response.body);
}) because the payload that gets sent is: {
"0": "127.0.0.1"
} Here is how it worked before: https://github.com/sendgrid/sendgrid-nodejs/blob/master/test/test.js#L4137 Any ideas? |
# Conflicts: # packages/helpers/classes/personalization.spec.js
@thinkingserious There was an issue with the merge data helper, I've fixed this in 3be7fd8 |
I'm not quite sure why those final two tests are failing. Locally, they work fine. I'll dig deeper. |
Awesome thanks for the release! Look forward to ongoing developments of this package. |
I did not, but now I have :) Thanks for the heads up! |
Hello @adamreisnz, |
You're welcome! Glad I could help out. |
@thinkingserious PR from monorepo to master