Expose client for testing stub-ability

[fyockm]

also ternary FTW

[thinkingserious]

@fyockm,

Awesome! Could you please take a moment to sign our CLA so I can merge this? https://github.com/sendgrid/sendgrid-nodejs/blob/master/CONTRIBUTING.md#cla

Thanks!

[thinkingserious]

Hi @fyockm,

This one finally came up to the top of our queue. Could you please repair the conflicts and I'll go ahead and merge it.

To test this locally:

1. Download https://stoplight.io/prism/
2. ./prism run --mock --list --spec https://raw.githubusercontent.com/sendgrid/sendgrid-oai/master/oai_stoplight.json
3. mocha

[thinkingserious]

@fyockm,

Just check in :)

[fyockm]

@thinkingserious I updated my branch. All tests pass locally.

#277 actually exposed the client already. So, this PR boils down to a more terse (though potentially less readable?) ternary expression around Promise. At this point, very little value added in my opinion. Feel free to merge or close.

[peteyycz]

@fyockm where does #277 expose the client? Your way is much clearer and it makes stubbing a lot easier, which is currently not doable.

Could you please update this branch because right now the library is untestable without modifications.

[thinkingserious]

@adamreisnz,

Does your version solve this issue?

[adamreisnz]

Yes it does actually :) It will be exposed as `sendgrid.restClient`.

…

On Fri, Apr 14, 2017, 05:59 Elmer Thomas ***@***.***> wrote: @adamreisnz <https://github.com/adamreisnz>, Does your version solve this issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#286 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAd8QovLGd_OdbS2Z5Yyhrav_csKFa37ks5rvmJjgaJpZM4Jz6V6> .

[thinkingserious]

This issue will be resolved with: #378