Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: event webhook interface to process raw body #1153

Merged
merged 4 commits into from
Jun 23, 2020
Merged

fix: event webhook interface to process raw body #1153

merged 4 commits into from
Jun 23, 2020

Conversation

eshanholtz
Copy link
Contributor

Fixes #1142

This PR updates the event webhook verification interface to accept string and Buffer type payloads, the preferred means of processing the event webhook request body. PR also adds the EventWebhookHeader class as well as a usage example.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 22, 2020
@eshanholtz eshanholtz mentioned this pull request Jun 23, 2020
Closed
childish-sambino
childish-sambino approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but given that this was a recent feature ship that's somewhat broken, I don't think it warrants a breaking tag.

childish-sambino
childish-sambino reviewed Jun 23, 2020
View reviewed changes
docs/use-cases/event-webhook.md Outdated Show resolved Hide resolved
docs/use-cases/event-webhook.md Outdated Show resolved Hide resolved
@eshanholtz eshanholtz changed the title fix!: event webhook interface to process raw body fix: event webhook interface to process raw body Jun 23, 2020
@eshanholtz eshanholtz merged commit 865f09d into master Jun 23, 2020
@eshanholtz eshanholtz deleted the fix-webhook branch June 23, 2020 16:42
@igrayson igrayson mentioned this pull request Aug 14, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

event webhook - please provide example for usage in express
3 participants
@eshanholtz @childish-sambino @thinkingserious