feat: console warning added when using an invalid API key #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
| this.defaultHeaders = { | ||
| 'Accept': 'application/json', | ||
| Accept: 'application/json', |
There was a problem hiding this comment.
Why do we convert to a non-string key here? Why only for the Accept key?
There was a problem hiding this comment.
Quotes aren't needed here and is an eslint warning.
| setApiKey(apiKey) { | ||
| this.apiKey = apiKey; | ||
|
|
||
| if (!this.isValidApiKey(apiKey)) { | ||
| console.warn(`API key does not start with ${API_KEY_PREFIX}`); |
There was a problem hiding this comment.
Here is a spot to put the message: https://github.com/sendgrid/sendgrid-nodejs/blob/master/packages/helpers/constants/index.js -- nit: period at the end.
There was a problem hiding this comment.
That's in the helpers package. I don't like defining the message in 1 package and using it in another.
thinkingserious
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1068