fix: Move @types/request back to dependencies #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
lirbank
suggested changes
Jan 24, 2020
notheotherben
approved these changes
Jan 24, 2020
childish-sambino
approved these changes
Jan 27, 2020
childish-sambino
changed the title
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1027.
This moves the
@types/requestdependency back into the non-dev category, unbreaking the package for TypeScript users. This is described as best practice here:https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#dependencies
I also bumped the version up from 2.0.4, which was two years old, to 2.48.4. I am unsure how DefinitelyTyped versions their types packages... but request v2.88.0 is the most recent version on NPM, so I assume y'all want the latest @types/request version also.