Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove chai from dependencies #1030

Merged
merged 1 commit into from
Jan 22, 2020
Merged

fix: remove chai from dependencies #1030

merged 1 commit into from
Jan 22, 2020

Conversation

thinkingserious
Copy link
Contributor

chai is only needed as a development dependency.

Checklist

  • I acknowledge that all my contributions will be made under the project's license

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: easy fix is easy in difficulty labels Jan 22, 2020
@eshanholtz eshanholtz merged commit 8e35d09 into master Jan 22, 2020
@thinkingserious
Copy link
Contributor Author

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@eshanholtz eshanholtz deleted the remove-chai branch January 22, 2020 21:22
@commit-lint commit-lint bot mentioned this pull request Jan 22, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 28, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkingserious @eshanholtz