Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modify request #758

Merged
merged 1 commit into from
Jun 27, 2024
Merged

chore: Modify request #758

merged 1 commit into from
Jun 27, 2024

Conversation

sbansla
Copy link

@sbansla sbansla commented Jun 27, 2024

Fixes

Remove Builder pattern from request as it creates difficulty in inheritance.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@sbansla sbansla changed the base branch from main to 5.0.0-rc June 27, 2024 04:40
@sbansla sbansla changed the title Modify request chore: Modify request Jun 27, 2024
@sbansla sbansla merged commit ce4e8e8 into 5.0.0-rc Jun 27, 2024
9 of 11 checks passed
@sbansla sbansla deleted the modify-request branch June 27, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant