Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add contribution guide for first-timers #491

Merged
merged 1 commit into from
Aug 18, 2020
Merged

docs: add contribution guide for first-timers #491

merged 1 commit into from
Aug 18, 2020

Conversation

daniloff200
Copy link
Contributor

@daniloff200 daniloff200 commented Oct 9, 2018 •
edited
Loading

Closes #490

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

This PR adds a First Timers.MD with a guideline for newcomers

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 9, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 9, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@agnesjang98 agnesjang98 added hacktoberfest difficulty: medium fix is medium in difficulty type: docs update documentation change not affecting the code labels Oct 11, 2018
@daniloff200
Copy link
Contributor Author

Hey @thinkingserious ! Are you able and have time to review and merge this PR ?

@daniloff200
Copy link
Contributor Author

hey @thinkingserious !
That's more than 1 year after last comment here :)

Can this PR be merged sometime?

@childish-sambino childish-sambino removed the type: docs update documentation change not affecting the code label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:33
@childish-sambino childish-sambino changed the title add contribution guide for first-timers docs: add contribution guide for first-timers Aug 18, 2020
@childish-sambino childish-sambino merged commit e71c7b0 into sendgrid:main Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create first time contributor documentation
5 participants
@daniloff200 @SendGridDX @childish-sambino @thinkingserious @agnesjang98