Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to check year in license file #365

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

pushkyn
Copy link
Contributor

@pushkyn pushkyn commented Oct 28, 2017

Closes: #354

Description of the change:

If you have questions, please send an email Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@pushkyn pushkyn force-pushed the test-license-date-range branch 3 times, most recently from 798d70f to 8e7aaf5 Compare October 30, 2017 14:48
@mbernier
Copy link
Contributor

mbernier commented Nov 1, 2017

@pushkyn I am not seeing this run in the Travis build are you seeing it run?

@pushkyn pushkyn force-pushed the test-license-date-range branch 2 times, most recently from f9d8b68 to 3032125 Compare November 1, 2017 05:08
@pushkyn
Copy link
Contributor Author

pushkyn commented Nov 1, 2017

hi @mbernier , I have run this test locally and and it was successfully completed. Currently I don't see any errors in travis build related with my test.

@@ -0,0 +1,27 @@
package com.sendgrid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking that this isn't running due to being in the wrong path? We have some other tests here: https://github.com/sendgrid/sendgrid-java/tree/master/src that are running in Travis. Can you please move this file there?

@mbernier mbernier merged commit fe032c9 into sendgrid:master Nov 21, 2017
@thinkingserious
Copy link
Contributor

Hello @pushkyn,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range
4 participants