Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display reportable interim fields as result variables in results report #141

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

xispa
Copy link
Member

@xispa xispa commented Aug 25, 2023

Description of the issue/feature this PR addresses

Important

Please review and merge senaite/senaite.core#2365 first

This Pull Request adds a footer section in results table where the interim fields flagged with report=True are displayed.

Current behavior before PR

Interim fields flagged with report=True are not displayed and there is no function to get them easily

Desired behavior after PR is merged

Interim fields flagged with Report=True are displayed and there is an easy function to get them.

Result variables in Calculation/Service:

Captura de 2023-08-25 12-21-18

Results entry:

Captura de 2023-08-25 12-10-10

Results report:

Captura de 2023-08-25 12-23-17

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski August 25, 2023 10:25
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for this one

@ramonski ramonski merged commit f428c74 into 2.x Aug 25, 2023
@ramonski ramonski deleted the display-reportable-interims branch August 25, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants