Improve performance of analysis verification #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Verification Timings per Analysis
Improved Verification Timings per Analysis
|
|
Some further improvement can be achieved with this change in 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR speeds up the verification process from
2-3 seconds to 0.5 seconds~200ms to ~125ms per Analysis.Current behavior before PR
The
after_verifyWF event handler tries to transition the parent sample after each analysis verification toverified.Desired behavior after PR is merged
The
after_verifyWF event handler checks first if all Analyses are in the stateverifiedbefore trying to transition the parent toverified--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.