Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Attribute Error in Upgrade Step 2619 #2642

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Nov 9, 2024

Description of the issue/feature this PR addresses

This PR handles the following error in Upgrade Step 2619 that was introduced in #2537:

Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 176, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 385, in publish_module
  Module ZPublisher.WSGIPublisher, line 288, in publish
  Module ZPublisher.mapply, line 85, in mapply
  Module ZPublisher.WSGIPublisher, line 63, in call_object
  Module Products.GenericSetup.tool, line 1135, in manage_doUpgrades
  Module Products.GenericSetup.upgrade, line 185, in doStep
  Module senaite.core.upgrade.v02_06_000, line 2192, in setup_result_types
AttributeError: 'NoneType' object has no attribute 'get'

Current behavior before PR

Traceback occurs due to a false indexed object in the UID catalog

Desired behavior after PR is merged

Error is handled gracefully and an error log is printed

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa merged commit ca09802 into 2.x Nov 11, 2024
2 checks passed
@xispa xispa deleted the fix-attribute-error-in-upgrade-step-2619 branch November 11, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants