Fix analysis categories are not sorted by sort key

CHANGES.rst

@@ -4,6 +4,7 @@ Changelog
 2.6.0 (unreleased)
 ------------------
 
+- #2619 Fix analysis categories are not sorted by sort key
 - #2618 Fix UnicodeDecodeError when user linked to a contact with special chars
 - #2615 Add control for select/deselect all attachments when send report
 - #2614 Fix autofill for simple fields when create Sample in the add form

src/senaite/core/catalog/indexer/analysiscategory.py

@@ -18,10 +18,10 @@
 # Copyright 2018-2024 by it's authors.
 # Some rights reserved, see README and LICENSE.
 
-from bika.lims.interfaces import IAnalysisCategory
 from plone.indexer import indexer
 from Products.CMFPlone.utils import safe_callable
 from senaite.core.catalog.utils import sortable_sortkey_title
+from senaite.core.interfaces import IAnalysisCategory
 
 
 @indexer(IAnalysisCategory)

src/senaite/core/profiles/default/metadata.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <metadata>
-  <version>2650</version>
+  <version>2651</version>
   <dependencies>
     <dependency>profile-Products.ATContentTypes:base</dependency>
     <dependency>profile-Products.CMFEditions:CMFEditions</dependency>

src/senaite/core/upgrade/v02_06_000.py

@@ -2480,3 +2480,13 @@ def fix_corrupted_transitions(tool):
                 wapi.update_transition(transition, after_script="")
 
     logger.info("Fixing corrupted transitions [DONE]")
+
+
+def reindex_analysis_categories(tool):
+    logger.info("Reindexing analysis categories ...")
+    cat = api.get_tool(SETUP_CATALOG)
+    for brain in cat(portal_type="AnalysisCategory"):
+        obj = brain.getObject()
+        logger.info("Reindex analysis category: %r" % obj)
+        obj.reindexObject(idxs=["sortable_title"], update_metadata=False)
+    logger.info("Reindexing analysis categories [DONE]")

src/senaite/core/upgrade/v02_06_000.zcml

@@ -3,6 +3,14 @@
     xmlns:genericsetup="http://namespaces.zope.org/genericsetup"
     i18n_domain="senaite.core">
 
+  <genericsetup:upgradeStep
+      title="SENAITE.CORE 2.6.0: Fix categories not sorted by sort key"
+      description="Reindex sortable_title for all analysis categories"
+      source="2650"
+      destination="2651"
+      handler=".v02_06_000.reindex_analysis_categories"
+      profile="senaite.core:default"/>
+
   <genericsetup:upgradeStep
       title="SENAITE.CORE 2.6.0: Fix corrupted transitions"
       description="Restores the value of the property `after_script_name` from