Migrate AnalysisCategories to DX #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for analysis category
|
@xispa Hi, this PR ready for review. pls, check it |
xispa
added
Python 3
xispa
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Thanks @Bugerman58 !
There is a subscriber that reindexes all sample analyses when the title of the category changes. This subscriber won't be called because the event is only triggered for AT content types. I do know that the dance is weird, takes ages to complete and is something we need to fix. But keep it for now, please. I will open a PR after yours to remove the getCategoryTitle metadata and fix that thing. Meanwhile, please create a new subscriber specific for analysiscategory at senaite.core.subscribers.
This was referenced Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR migrates the AT AnalysisCategory and AnalysisCategories to Dexterity types for Python 3 compatibility.
Current behavior before PR
AnalysisCategory and AnalysisCategories are content types based on the Archetypes framework
Desired behavior after PR is merged
AnalysisCategory and AnalysisCategories are content types based on the Dexterity framework
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.