Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing required marker in edit forms #2443

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fix missing required marker in edit forms #2443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edac6e8
Fix missing required marker in edit forms
ramonski Dec 5, 2023
4a83a40
Changelog updated
ramonski Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changelog
2.5.0 (unreleased)
------------------

- #2443 Fix missing required marker in edit forms
- #2441 Fix items count in setupview for lab contacts tile
- #2440 Fix multi Code_128_1x48mm sticker renders only 1 PDF
- #2439 Fix analysis template view shows hidden subfields for sample partitions
Expand Down
2 changes: 1 addition & 1 deletion src/senaite/core/browser/static/bundles/senaite.core.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/senaite/core/browser/static/bundles/senaite.core.css.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 8 additions & 1 deletion webpack/app/scss/forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,21 @@
}
}

form[name='edit_form'] div.listing-container {
input, select {
@extend .form-control;
width: 100%!important;
}
}

ul.configlets>li>form,
form.rowlike,
form.loginform,
form.senaite-form,
form[name='analysisrequest_add_form'],
form[action*='-controlpanel'],
form[name='sampleheader_form'],
form[name='edit_form'] :not(.ajax-contents-table) div > {
form[name='edit_form'] {
input, select {
width: auto;
}
Expand Down