-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to keep from HEAD after revert #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're on the right track. Please make separate PRs for the separate issues you've identified such as adding a top-level allow deprecated lint and updating the GitHub actions config.
removed the version bumps, created the two PRs linked (also removing these PRs code changes) |
Just one question, is it better to push the separate PRs in this case into directly (merging the allows deprecated branch here will solve the clippy issue) |
This keeps some of the changes in the veemon crate that are not related to the reth revert, while revertinig to use reth as before. The part of reverting to reth is done in https://github.com/semiotic-ai/veemon/tree/revert-to-e13870
One of my concerns here is that reth-primitives
TransactioniSigned
(below) depends onSignature
fromalloy_priimitivies
which is now marked as deprecated.In this case, I think we should allow the warnings for now, whiile we convert properly to use alloy only as it was suggested. These deprecated warnings will be removed as soon as PRs like this are mergeed: #74 that make sure examples and tests work properly with alloy are pushed.
A summary of what is kept after reverting to reth:
Cargo.toml
that do not affect our codetransaction.rs
header_accumulator
andvee
, ` from the 41d8900It does keep reversion of version bumps of
decoder
, because it keeps previous reth import.