Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for HPCombi #978

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fix for HPCombi #978

merged 3 commits into from
Jan 24, 2024

Conversation

james-d-mitchell
Copy link
Collaborator

No description provided.

@james-d-mitchell james-d-mitchell changed the title Hpcombi Fix for Hpcombi Jan 23, 2024
@james-d-mitchell james-d-mitchell added the C++ language Label for PR/issues related to the kernel module label Jan 23, 2024
@james-d-mitchell james-d-mitchell changed the title Fix for Hpcombi Fix for HPCombi Jan 23, 2024
@james-d-mitchell james-d-mitchell changed the title Fix for HPCombi Fix for HPCombi Jan 23, 2024
@james-d-mitchell james-d-mitchell mentioned this pull request Jan 23, 2024
Closed
@james-d-mitchell
Copy link
Collaborator Author

@fingolfin @ChrisJefferson is seems that a few days ago the cygwin job started to fail with:

Error, LOAD_DYN: failed to load kernel module /tmp/gaproot/pkg/Semigroups//bin/x86_64\
-pc-cygwin-default64-kv9/semigroups.so, No such file or directory in
  LOAD_DYN( filename ) at /home/runneradmin/gap/lib/files.gd:619 called from

see, for example:

https://github.com/semigroups/Semigroups/actions/runs/7625232891/job/20769065765

Earlier in the log it can be seen that the executable /tmp/gaproot/pkg/Semigroups//bin/x86_64\ -pc-cygwin-default64-kv9/semigroups.so is built. This is not caused by anything in this PR (I don't think) since it appears to have started yesterday in the cron job:

https://github.com/semigroups/Semigroups/actions/runs/7606076562

If either of you have any ideas how to resolve this I'd be most grateful to hear about it.

@ChrisJefferson
Copy link
Contributor

We always had to do some slightly special things to get files in the right place. I will investigate and get back to you.

@james-d-mitchell
Copy link
Collaborator Author

Thanks @ChrisJefferson !

@james-d-mitchell
ci: add job with hpcombi enabled
c12286a
@james-d-mitchell
build: fix AX_CHECK_HPCOMBI
dfb1735 
Previously the paths were incorrect, probably copied from libsemigroups
directly, and so HPCombi was never found.  This commit also ensures that
HPCOMBI_CXXFLAGS are added to CXX_FLAGS, which they previously weren't.
@james-d-mitchell
kernel: fix for HPCombi
f7c49df 
There was some missing functionality that compiling with HPCombi enabled
required. This commit adds that functionality and fixes a FIXME that
actually comes up in semiquo.tst when compiling with HPCombi enabled.
@james-d-mitchell james-d-mitchell merged commit 84339da into semigroups:stable-5.3 Jan 24, 2024
14 checks passed
@james-d-mitchell james-d-mitchell deleted the hpcombi-ci branch January 24, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C++ language Label for PR/issues related to the kernel module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-d-mitchell @ChrisJefferson