buildsystem: sane warning if not using gmake #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
added
the
build-system
fingolfin
reviewed
Sep 14, 2023
fingolfin
reviewed
Sep 14, 2023
fingolfin
reviewed
Sep 14, 2023
fingolfin
reviewed
Sep 14, 2023
james-d-mitchell
force-pushed
the
non-gmake-warning
branch
from
99811a9
to
40879f9
Compare
|
This seems to work on Mac OSX, and has the desired behaviour on openbsd too (where I first noticed the issue that this PR resolves). Will merge if the CI passes ok too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to follow
#947 (comment)
so that a sane warning is emitted if trying to use
makeinstead ofgmake. Hopefully resolves #952. Thanks @fingolfin for the hints!