Adjust for compatibility with all packages loaded #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
force-pushed
the
adjust-tests
branch
from
518230d to
f80aedb
Compare
|
Looks good, can you remind me (or do it) about the commented out test? I'm working on the fix for Issue #536 now. |
|
Also if this resolves Issue #543, then could you please indicate that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
and an adjustment to a filter in, the next release of the Semigroups package should pass in Alexander's tests where all the packages are loaded.smallsemithat I mentioned in #543 (comment)Not that this required me to adjust an iterator test for free inverse semigroups; @james-d-mitchell has adjusted this code and presumably the tests, so it would be best to merge this after that fix has been pushed (in case this will need rebasing).
I added
SUM_FLAGSto the method rank ofIsOrthodoxSemigroupso that Semigroups beats smallsemi. Ideally1should be enough of an adjustment to make this happen, but until the current GAP master branch, method rank stuff was broken in GAP, and this is the simplest way to avoid the brokenness of GAP.Doing this avoids needing to make changes to
smallsemi.