Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Nambooripad #1026

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Tianrun-Y
Copy link
Collaborator

A faster way of finding the Nambooripad Partial Order (aka natural partial order and Mitsch order) of a finite regular semigroup.

@Tianrun-Y Tianrun-Y changed the title Improve the current nambooripad partial order method Better Nambooripad Jul 31, 2024
@james-d-mitchell
Copy link
Collaborator

Thanks for the contribution @Tianrun-Y, can you please give an example which indicates why we should prefer the new method over the older method?

@james-d-mitchell james-d-mitchell added the performance A label for issues or PRs that relate to performance. label Jul 31, 2024
@Tianrun-Y
Copy link
Collaborator Author

Old version
gap> S:=FullTransformationMonoid(4);;
gap> NambooripadPartialOrder(S);;time;
3445

New version
gap> S:=FullTransformationMonoid(4);;
gap> NambooripadPartialOrder(S);;time;
136

@james-d-mitchell
Copy link
Collaborator

Can you please add the example to the relevant test file? Then I'll be happy to merge, and thanks very much!

@Tianrun-Y
Copy link
Collaborator Author

Can you please add the example to the relevant test file? Then I'll be happy to merge, and thanks very much!

Test added with time included as a comment. Hope this is good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A label for issues or PRs that relate to performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants