Fix stable-4.12 #1015
Merged
Fix stable-4.12 #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, this proved harder to fix, because GAP 4.12 won't go look for homebrew gmp (later versions do). At this point, we could write a quick special script, just for stable-4.12 macos, to get the right GMP, but before doing that, I wanted to check if you'd be happy instead just switching to checking master and stable-4.13, and dropping testing 4.12, or only testing 4.12 on ubuntu?s |
|
Thanks @ChrisJefferson, I think just not testing GAP 4.12.2 on macosx is the best solution, thanks so much for the work you did on this! |
james-d-mitchell
force-pushed
the
chris-fix
branch
from
0bd3990
to
2d10527
Compare
|
I merged #1012, and then cherry-picked your commits onto stable-5.3, will auto merge this. Thanks @ChrisJefferson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will (hopefully) fix stable-4.12 on macs (by using 'brew' to install gmp instead of using the internal one because it's too old).
I also pulled in #1012 , as I need that for CI to pass, and updated my website at the same time (as St Andrews shut all the cs.host websites)