Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Move On Sui Semgrep grammer #508

Merged
merged 11 commits into from
Sep 17, 2024
Merged

Adding Move On Sui Semgrep grammer #508

merged 11 commits into from
Sep 17, 2024

Conversation

maxmysten
Copy link
Contributor

Checklist

  • Any new parsing code was already published, integrated, and merged into Semgrep. DO NOT MERGE THIS PR BEFORE THE SEMGREP INTEGRATION WORK WAS COMPLETED.
  • [X ] Change has no security implications (otherwise, ping the security team)

maxmysten added 11 commits August 17, 2024 01:45
@maxmysten
First instance of adding semgrep grammars for Move-on-Sui language.
faf9cfc 
Currently everything in the tree-sitter grammer is fully supported and all tests pass.

However, several things are missing from the tree-sitter grammar today:
- Proper support for annotations
- Support for scripts
- The most recent changes to the Move language
@maxmysten
Moving Move on Sui tree-sitter to my branch for accelerated developement
5eb5670
@maxmysten
Merge branch 'semgrep:main' into main
1a671ca
@maxmysten
Added a package to stats, this has a lot of tests that are updated wi…
eb29b83 
…th move as this is a vscode highigher
@maxmysten
Fixing Macro parsing bug due to meta variables eating the $ and 1 onl…
563212b 
…y upcase chars
@maxmysten
updating tree-sitter-move-on-sui repo
60a2f69
@maxmysten
Fixing Macros so now macro variables that start with $ parse.
2ecb3fd
@maxmysten
Simplifying _identifier_or_metavariable
2af6a62
@maxmysten
Adding ellipsis to module_access
36dc663
@maxmysten
Merge branch 'semgrep:main' into main
a8d4a50
@maxmysten
Merge branch 'semgrep:main' into main
4d01142
@maxmysten maxmysten requested a review from a team as a code owner September 15, 2024 00:23
@maxmysten maxmysten requested a review from aryx September 15, 2024 00:23
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nmote
Copy link
Collaborator

nmote commented Sep 16, 2024

Could you share some context on this language? How similar is it to Move on Aptos?

aryx
aryx approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@aryx aryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmote move on aptos is a fork of move on sui (more or less).

@aryx aryx merged commit d14c9ac into semgrep:main Sep 17, 2024
2 checks passed
@aryx
Copy link
Collaborator

aryx commented Sep 17, 2024

@maxmysten FYI I get this on ./test-lang move-on-sui:

...
Warning: unnecessary conflicts
  `module_access`, `typed_metavariable`
  `annotation_expr`, `module_access`
  `annotation_expression`, `typed_metavariable`
  `module_access`, `variable_identifier`

@aryx
Copy link
Collaborator

aryx commented Sep 17, 2024

@maxmysten I've pushed a new semgrep-move-on-sui. You can then use that from the semgrep repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryx aryx aryx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxmysten @CLAassistant @nmote @aryx