Simple authorization via LDAP #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for doing this 👍 |
|
All done, code available for review. :) |
ruriky
suggested changes
Mar 29, 2017
api/login.go
Outdated
| util.Config.LdapSearchDN, | ||
| ldap.ScopeWholeSubtree, ldap.NeverDerefAliases, 0, 0, false, | ||
| fmt.Sprintf(util.Config.LdapSearchFilter, auth), | ||
| []string{"dn", "mail", "uid", "cn"}, |
There was a problem hiding this comment.
Would be nice to get these searched parameters configurable. For example our AD doesn't have "uid" parameter at all for the user object and the "cn" doesn't contain user's name but some identification string.
ruriky
reviewed
Mar 29, 2017
util/config.go
Outdated
| @@ -231,4 +240,59 @@ func (conf *configType) Scan() { | |||
| conf.EmailAlert = false | |||
| } | |||
|
|
|||
| var LdapAnswer string | |||
| fmt.Print(" > Enable LDAP authentificaton (y/n, default n): ") | |||
There was a problem hiding this comment.
Whoops, thank you.
|
@ruriky All done! Sorry for the delay, I caught the flu. :( |
|
Thank you strangeman for taking the time to implementing the changes I suggested. I'm happy with the current state of this change. |
ruriky
approved these changes
Apr 4, 2017
|
hey, is there any eta on when it will get merge to the tree? |
|
Thanks guys! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Algorithm: #118 (comment)
I have some doubts about my code:
println, because I can't see any logs except Gin logging2.3.0.sqlbecause 2.3.0 isn't released. Is it ok?