Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add content to response of post /project/{project_id}/inventory #289

Merged
merged 4 commits into from
Mar 11, 2017
Merged

add content to response of post /project/{project_id}/inventory #289

merged 4 commits into from
Mar 11, 2017

Conversation

laeshiny
Copy link
Contributor

implement #279

add content to response of post /project/{project_id}/inventory

matejkramny
matejkramny suggested changes Mar 11, 2017
View reviewed changes
Copy link
Contributor

@matejkramny matejkramny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should return HTTP 201 (Created)
  • The inventory call should assign the ID to the inventory object and return that instead of recreating

laeshiny added 2 commits March 11, 2017 14:47
@laeshiny
correct the response content and code
89fc1f7 
- add an inventory id to the response content
- replace the response code to 201 (Created)
@laeshiny
correct the response code in api document
2590b14
@laeshiny
Copy link
Contributor Author

laeshiny commented Mar 11, 2017 •
edited
Loading

Thank you for your review.
I corrected what you reviewed.

@matejkramny matejkramny merged commit 51c7ea8 into semaphoreui:develop Mar 11, 2017
@matejkramny matejkramny mentioned this pull request Mar 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejkramny matejkramny matejkramny requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laeshiny @matejkramny