Fix zombie processes by calling Wait after Command.Run

semaphoreui · Mar 8, 2017 · 9cb2ed1 · 9cb2ed1
1 parent e6d98c9
commit 9cb2ed1
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/api/tasks/runner.go b/api/tasks/runner.go
@@ -253,6 +253,7 @@ func (t *task) updateRepository() error {
 	}
 
 	t.logCmd(cmd)
+	defer cmd.Wait()
 	return cmd.Run()
 }
 
@@ -277,6 +278,7 @@ func (t *task) runGalaxy() error {
 	}
 
 	t.logCmd(cmd)
+	defer cmd.Wait()
 	return cmd.Run()
 }
 
@@ -327,6 +329,7 @@ func (t *task) runPlaybook() error {
 	cmd.Env = t.envVars(util.Config.TmpPath, cmd.Dir, nil)
 
 	t.logCmd(cmd)
+	defer cmd.Wait()
 	return cmd.Run()
 }